gallium/hud: prevent buffer overflow

Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
This commit is contained in:
Eric Engestrom 2019-03-19 14:11:48 +00:00 committed by Eric Engestrom
parent 4633d13854
commit 9d6ea55263
3 changed files with 6 additions and 6 deletions

View file

@ -213,7 +213,7 @@ add_object_part(const char *basename, const char *name, int objmode)
{
struct diskstat_info *dsi = CALLOC_STRUCT(diskstat_info);
strcpy(dsi->name, name);
snprintf(dsi->name, sizeof(dsi->name), "%s", name);
snprintf(dsi->sysfs_filename, sizeof(dsi->sysfs_filename), "%s/%s/stat",
basename, name);
dsi->mode = objmode;
@ -226,7 +226,7 @@ add_object(const char *basename, const char *name, int objmode)
{
struct diskstat_info *dsi = CALLOC_STRUCT(diskstat_info);
strcpy(dsi->name, name);
snprintf(dsi->name, sizeof(dsi->name), "%s", name);
snprintf(dsi->sysfs_filename, sizeof(dsi->sysfs_filename), "%s/stat",
basename);
dsi->mode = objmode;

View file

@ -114,7 +114,7 @@ query_wifi_bitrate(const struct nic_info *nic, uint64_t *bitrate)
memset(&stats, 0, sizeof(stats));
memset(&req, 0, sizeof(req));
strcpy(req.ifr_name, nic->name);
snprintf(req.ifr_name, sizeof(req.ifr_name), "%s", nic->name);
req.u.data.pointer = &stats;
req.u.data.flags = 1;
req.u.data.length = sizeof(struct iw_statistics);
@ -145,7 +145,7 @@ query_nic_rssi(const struct nic_info *nic, uint64_t *leveldBm)
memset(&stats, 0, sizeof(stats));
memset(&req, 0, sizeof(req));
strcpy(req.ifr_name, nic->name);
snprintf(req.ifr_name, sizeof(req.ifr_name), "%s", nic->name);
req.u.data.pointer = &stats;
req.u.data.flags = 1;
req.u.data.length = sizeof(struct iw_statistics);

View file

@ -259,8 +259,8 @@ create_object(const char *chipname, const char *featurename,
sti->mode = mode;
sti->chip = (sensors_chip_name *) chip;
sti->feature = feature;
strcpy(sti->chipname, chipname);
strcpy(sti->featurename, featurename);
snprintf(sti->chipname, sizeof(sti->chipname), "%s", chipname);
snprintf(sti->featurename, sizeof(sti->featurename), "%s", featurename);
snprintf(sti->name, sizeof(sti->name), "%s.%s", sti->chipname,
sti->featurename);