fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-26 21:30:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panvk/jm: Move cmd_prepare_draw_sysvals() out of the layer loop

Browse source 
The only sysval that changes is the layer_id, so let's call
cmd_prepare_draw_sysvals() outside of the layer loop, and manually
update the sysval there.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32540>
This commit is contained in:
Boris Brezillon 2024-12-16 17:48:03 +01:00 • committed by Marge Bot
parent fe21da08ed
commit 9d5d03bf78
1 changed files with 13 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/panfrost/vulkan/jm/panvk_vX_cmd_draw.c
View file

@ -1274,22 +1274,25 @@ panvk_cmd_draw(struct panvk_cmd_buffer *cmdbuf, struct panvk_draw_data *draw)
return;
}
panvk_per_arch(cmd_prepare_draw_sysvals)(cmdbuf, &draw->info);
/* Viewport emission requires up-to-date {scale,offset}.z for min/max Z,
* so we need to call it after calling cmd_prepare_draw_sysvals(), but
* viewports are the same for all layers, so we only emit when layer_id=0.
*/
result = panvk_draw_prepare_viewport(cmdbuf, draw);
if (result != VK_SUCCESS)
return;
for (uint32_t i = 0; i < layer_count; i++) {
draw->info.layer_id = i;
result = panvk_draw_prepare_varyings(cmdbuf, draw);
if (result != VK_SUCCESS)
return;
panvk_per_arch(cmd_prepare_draw_sysvals)(cmdbuf, &draw->info);
/* Viewport emission requires up-to-date {scale,offset}.z for min/max Z,
* so we need to call it after calling cmd_prepare_draw_sysvals(), but
* viewports are the same for all layers, so we only emit when layer_id=0.
*/
if (i == 0) {
result = panvk_draw_prepare_viewport(cmdbuf, draw);
if (result != VK_SUCCESS)
return;
if (i > 0) {
cmdbuf->state.gfx.sysvals.layer_id = i;
gfx_state_set_dirty(cmdbuf, FS_PUSH_UNIFORMS);
}
result = panvk_per_arch(cmd_prepare_push_uniforms)(