fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-03 07:48:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel/isl: Explicitly set offset_B = 0 in get_uncomp_surf for arrays

Browse source 
The only user of this case is iris which initializes offset_B to 0 so
there's no real bug here.  However, it is unexpected from an API PoV.

Fixes: 9946120d2b "intel/isl: Add more cases to isl_surf_get_uncompressed_surf"
Acked-by: Ivan Briano <ivan.briano@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11765>
(cherry picked from commit 3702406154)
This commit is contained in:
Jason Ekstrand 2021-07-07 10:52:09 -05:00 • committed by Dylan Baker
parent 7afc784345
commit 9c01036e77
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -58,7 +58,7 @@
"description": "intel/isl: Explicitly set offset_B = 0 in get_uncomp_surf for arrays",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "9946120d2b4e898b58f5d255558a27affc78e928"
},

3
src/intel/isl/isl.c
View file

@ -2892,6 +2892,9 @@ isl_surf_get_uncompressed_surf(const struct isl_device *dev,
*ucompr_surf = *surf;
ucompr_surf->levels = 1;
/* The surface mostly stays as-is; there is no offset */
*offset_B = 0;
/* The view remains the same */
*ucompr_view = *view;
} else {