From 9bd8d26969c51916e1cb39e66864f033294b9409 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Pi=C3=B1eiro?= Date: Sun, 23 May 2021 23:09:58 +0200 Subject: [PATCH] v3d/simulator: add a cache flush mode enum Makes the write to the l2t cache control more readable (without magic numbers). Reviewed-by: Juan A. Suarez Part-of: --- src/broadcom/simulator/v3dx_simulator.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/broadcom/simulator/v3dx_simulator.c b/src/broadcom/simulator/v3dx_simulator.c index 2766f245adc..9fdf5921566 100644 --- a/src/broadcom/simulator/v3dx_simulator.c +++ b/src/broadcom/simulator/v3dx_simulator.c @@ -81,6 +81,12 @@ v3d_invalidate_l2c(struct v3d_hw *v3d) V3D_CTL_0_L2CACTL_L2CENA_SET); } +enum v3d_l2t_cache_flush_mode { + V3D_CACHE_FLUSH_MODE_FLUSH, + V3D_CACHE_FLUSH_MODE_CLEAR, + V3D_CACHE_FLUSH_MODE_CLEAN, +}; + /* Invalidates texture L2 cachelines */ static void v3d_invalidate_l2t(struct v3d_hw *v3d) @@ -89,7 +95,7 @@ v3d_invalidate_l2t(struct v3d_hw *v3d) V3D_WRITE(V3D_CTL_0_L2TFLEND, ~0); V3D_WRITE(V3D_CTL_0_L2TCACTL, V3D_CTL_0_L2TCACTL_L2TFLS_SET | - (0 << V3D_CTL_0_L2TCACTL_L2TFLM_LSB)); + (V3D_CACHE_FLUSH_MODE_FLUSH << V3D_CTL_0_L2TCACTL_L2TFLM_LSB)); } /* Flushes dirty texture cachelines from the L1 write combiner */ @@ -110,7 +116,7 @@ v3d_flush_l2t(struct v3d_hw *v3d) V3D_WRITE(V3D_CTL_0_L2TFLEND, ~0); V3D_WRITE(V3D_CTL_0_L2TCACTL, V3D_CTL_0_L2TCACTL_L2TFLS_SET | - (2 << V3D_CTL_0_L2TCACTL_L2TFLM_LSB)); + (V3D_CACHE_FLUSH_MODE_CLEAN << V3D_CTL_0_L2TCACTL_L2TFLM_LSB)); assert(!(V3D_READ(V3D_CTL_0_L2TCACTL) & V3D_CTL_0_L2TCACTL_L2TFLS_SET)); }