From 9b0fc62221afa8da836d44e12e1a7e2cd33546bf Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Thu, 2 Jan 2025 22:36:55 -0800 Subject: [PATCH] vulkan: Add missing va_end Fix defect reported by Coverity Scan. Missing varargs init or cleanup (VARARGS) missing_va_end: va_end was not called for ap. Fixes: f8b584d6a5f7 ("vulkan/runtime,radv: Add shared BVH building framework") Signed-off-by: Vinson Lee Reviewed-by: Lionel Landwerlin Part-of: --- src/vulkan/runtime/vk_acceleration_structure.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vulkan/runtime/vk_acceleration_structure.c b/src/vulkan/runtime/vk_acceleration_structure.c index 0ea4ea7bf8c..cce1617962e 100644 --- a/src/vulkan/runtime/vk_acceleration_structure.c +++ b/src/vulkan/runtime/vk_acceleration_structure.c @@ -462,8 +462,10 @@ vk_accel_struct_cmd_begin_debug_marker(VkCommandBuffer commandBuffer, va_start(ap, format); char *name; - if (vasprintf(&name, format, ap) == -1) + if (vasprintf(&name, format, ap) == -1) { + va_end(ap); return; + } va_end(ap);