From 9999cd3967bde637eaabbaf9a3d63586c7fc7f90 Mon Sep 17 00:00:00 2001 From: Yiwei Zhang Date: Sun, 10 Aug 2025 21:37:45 -0700 Subject: [PATCH] vulkan/util: no need to hide ANB property itself behind Android Property members are never going to use platform specific struct. Getting rid of the guard around sharedImage propperty simplifies driver side setting the prop. Reviewed-by: Lucas Fryzek Acked-by: Konstantin Seurer Part-of: --- .../util/vk_physical_device_properties_gen.py | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/vulkan/util/vk_physical_device_properties_gen.py b/src/vulkan/util/vk_physical_device_properties_gen.py index 712d570063d..baf78c46fd7 100644 --- a/src/vulkan/util/vk_physical_device_properties_gen.py +++ b/src/vulkan/util/vk_physical_device_properties_gen.py @@ -82,9 +82,8 @@ class Property: name: str actual_name: str length: str - is_android: bool - def __init__(self, p, property_struct_name, is_android=False): + def __init__(self, p, property_struct_name): self.decl = "" for element in p: if element.tag != "comment": @@ -100,8 +99,6 @@ class Property: self.decl = self.decl.replace(self.name, self.actual_name) - self.is_android = is_android - @dataclass class PropertyStruct: c_type: str @@ -162,13 +159,7 @@ extern "C" { struct vk_properties { % for prop in all_properties: -% if prop.is_android: -#if DETECT_OS_ANDROID -% endif ${prop.decl}; -% if prop.is_android: -#endif /* DETECT_OS_ANDROID */ -% endif % endfor }; @@ -331,7 +322,7 @@ def get_property_structs(doc, api, beta): elif m_name == "sType": s_type = p.attrib.get("values") else: - properties.append(Property(p, name, is_android)) + properties.append(Property(p, name)) property_struct = PropertyStruct(c_type=full_name, s_type=s_type, name=name, properties=properties, is_android=is_android)