From 998122d9c2a26bbfb2073ba9ac7fa833ce32fcd7 Mon Sep 17 00:00:00 2001 From: Simon Zeni Date: Mon, 3 Oct 2022 14:25:22 -0400 Subject: [PATCH] mesa: fix GL_INVALID_OPERATION in glEGLImageTargetTexStorageEXT Using EGLImages from DMA-BUF as target storage should return GL_INVALID_OPERATION if the target is not GL_TEXTURE_2D or GL_TEXTURE_EXTERNAL_OES. Fixes: 6a3f5c65 ("mesa: simplify st_egl_image binding process for texture storage") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18939 Signed-off-by: Simon Zeni Reviewed-by: Nanley Chery Part-of: --- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 88cea224420..4b1ad59aa11 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3557,7 +3557,7 @@ egl_image_target_texture(struct gl_context *ctx, * Otherwise, the error INVALID_OPERATION is generated. */ if (stimg.imported_dmabuf && - (target == GL_TEXTURE_2D || target == GL_TEXTURE_EXTERNAL_OES)) { + !(target == GL_TEXTURE_2D || target == GL_TEXTURE_EXTERNAL_OES)) { _mesa_error(ctx, GL_INVALID_OPERATION, "%s(texture is imported from dmabuf)", caller); return;