From 989f2d8b3444cb580799fcd77fdef13c35b1514a Mon Sep 17 00:00:00 2001 From: Guilherme Gallo Date: Mon, 3 Mar 2025 12:25:47 -0300 Subject: [PATCH] ci/lava: Propagate errors in SSH tests The `lava_ssh_test_case` wrapper was missing the `set -e` shell option, which made LAVA system interpret the job was succeeding, because the `container` namespace was exiting normally, even though the `dut` namespace was failing. Signed-off-by: Guilherme Gallo Part-of: (cherry picked from commit 1169f704d33dfe7781e7044b2dde2bc523e7dad3) --- .gitlab-ci/lava/utils/ssh_job_definition.py | 2 +- .pick_status.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci/lava/utils/ssh_job_definition.py b/.gitlab-ci/lava/utils/ssh_job_definition.py index 04d2f2af029..b486952f443 100644 --- a/.gitlab-ci/lava/utils/ssh_job_definition.py +++ b/.gitlab-ci/lava/utils/ssh_job_definition.py @@ -68,7 +68,7 @@ EOF ping -c 5 -w 60 $(lava-target-ip) lava_ssh_test_case() { - set -x + set -ex local test_case="${1}" shift lava-test-case \"${test_case}\" --shell \\ diff --git a/.pick_status.json b/.pick_status.json index 5583e13c98c..6ff174b60c8 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -644,7 +644,7 @@ "description": "ci/lava: Propagate errors in SSH tests", "nominated": false, "nomination_type": 0, - "resolution": 4, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null