fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 18:18:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

util/glsl2spirv: fix appending extra flags

Browse source 
The variable is called `extra`, but what's written is `extra - flags`,
and `flags` is undefined, so if the variable was ever passed there would
be an uncaught exception.

fixes: 9786d9ef2a

Reviewed-by: Luis Felipe Strano Moraes <luis.strano@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19449>
(cherry picked from commit 4ffa8a9ac0)
This commit is contained in:
Dylan Baker 2022-11-01 12:49:53 -07:00 • committed by Eric Engestrom
parent aececb9c4e
commit 986a55f9ba
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -3028,7 +3028,7 @@
"description": "util/glsl2spirv: fix appending extra flags",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "9786d9ef2abb45a4e832cf1347581e3ca3aae9f0"
},

2
src/util/glsl2spirv.py
View file

@ -136,7 +136,7 @@ def process_file(args):
cmd_list += ["--variable-name", args.vn]
if args.extra is not None:
cmd_list.append(args.extra-flags)
cmd_list.append(args.extra)
if args.create_entry is not None:
cmd_list += ["--entry-point", args.create_entry]