fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 19:58:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

agx: don't produce split of immediate

Browse source 
can't be consumed, affects KHR-GL42.shader_image_load_store.basic-allTargets-load-ms

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26614>
This commit is contained in:
Alyssa Rosenzweig 2023-12-01 17:24:10 -04:00
parent 6e2c71dc3b
commit 982e644d18
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/asahi/compiler/agx_compile.c
View file

@ -249,6 +249,12 @@ agx_subdivide_to(agx_builder *b, agx_index dst, agx_index s0, unsigned comp)
assert((s0.size == (dst.size + 1)) && "only 2x subdivide handled");
assert((comp == 0 || comp == 1) && "too many components");
/* Handle immediates specially so we don't have to constant fold splits. */
if (s0.type == AGX_INDEX_IMMEDIATE) {
unsigned bits = 16 * agx_size_align_16(dst.size);
return agx_mov_imm_to(b, dst, (s0.value >> bits) & BITFIELD64_MASK(bits));
}
agx_instr *split = agx_split(b, 2, s0);
split->dest[comp] = dst;
split->dest[1 - comp] = agx_temp(b->shader, dst.size);

2
src/asahi/compiler/agx_optimizer.c
View file

@ -163,6 +163,8 @@ agx_optimizer_inline_imm(agx_instr **defs, agx_instr *I, unsigned srcs,
if ((I->op == AGX_OPCODE_LOCAL_LOAD || I->op == AGX_OPCODE_DEVICE_LOAD) &&
s != 1)
continue;
if (I->op == AGX_OPCODE_SPLIT)
continue;
if (I->op == AGX_OPCODE_IMAGE_WRITE &&
!image_write_source_can_be_immediate(I, s))