From 981ff774314e2f1b3c56e93ace5acb532a5241d8 Mon Sep 17 00:00:00 2001
From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Date: Sun, 22 Sep 2024 21:52:58 -0400
Subject: [PATCH] agx: validate phi sources are defined

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
---
 src/asahi/compiler/agx_validate.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/asahi/compiler/agx_validate.c b/src/asahi/compiler/agx_validate.c
index 22a93ed508a..943edc247fd 100644
--- a/src/asahi/compiler/agx_validate.c
+++ b/src/asahi/compiler/agx_validate.c
@@ -500,6 +500,20 @@ agx_validate(agx_context *ctx, const char *after)
          }
       }
 
+      /* agx_validate_defs skips phi sources, so validate them now */
+      agx_foreach_block(ctx, block) {
+         agx_foreach_phi_in_block(block, phi) {
+            agx_foreach_ssa_src(phi, s) {
+               if (!BITSET_TEST(defs, phi->src[s].value)) {
+                  fprintf(stderr, "Undefined phi source %u after %s\n",
+                          phi->src[s].value, after);
+                  agx_print_instr(phi, stderr);
+                  fail = true;
+               }
+            }
+         }
+      }
+
       free(defs);
    }