From 97d307406b202e5494bf65544500dc084bf8ca6d Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sun, 18 Sep 2022 15:39:37 -0700 Subject: [PATCH] radv: Use count_tes_user_sgprs return value. Fix defect reported by Coverity Scan. Useless call (USELESS_CALL) side_effect_free: Calling count_tes_user_sgprs(key) is only useful for its return value, which is ignored. Fixes: 8253ec3855a ("radv: add shader arguments for dynamic patch control points") Signed-off-by: Vinson Lee Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_shader_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader_args.c b/src/amd/vulkan/radv_shader_args.c index 84c316f3ece..8bdae45cfaa 100644 --- a/src/amd/vulkan/radv_shader_args.c +++ b/src/amd/vulkan/radv_shader_args.c @@ -214,7 +214,7 @@ allocate_user_sgprs(enum amd_gfx_level gfx_level, const struct radv_shader_info user_sgpr_count += 1; /* tcs_offchip_layout */ break; case MESA_SHADER_TESS_EVAL: - count_tes_user_sgprs(key); + user_sgpr_count += count_tes_user_sgprs(key); break; case MESA_SHADER_GEOMETRY: if (has_previous_stage) {