fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-04 10:40:36 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

lavapipe: fix depth bias offset flag enables.

Browse source 
When vulkan enables depth bias, enable it for all 3 prim types
in gallium.

This fixes:
dEQP-VK.draw.renderpass.depth_bias.depth_bias_*
and
one zink test in CI

Cc: mesa-stable
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16701>
(cherry picked from commit 4896e136b6)
This commit is contained in:
Dave Airlie 2022-05-25 13:28:43 +10:00 • committed by Dylan Baker
parent b7b727f561
commit 96a45c87ca
3 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -418,7 +418,7 @@
"description": "lavapipe: fix depth bias offset flag enables.",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

1
src/gallium/drivers/zink/ci/zink-lvp-fails.txt
View file

@ -160,7 +160,6 @@ spec@!opengl 1.1@linestipple@Factor 2x,Fail
spec@!opengl 1.1@linestipple@Factor 3x,Fail
spec@!opengl 1.1@linestipple@Line loop,Fail
spec@!opengl 1.1@linestipple@Line strip,Fail
spec@!opengl 1.1@polygon-offset,Fail
spec@!opengl 1.1@polygon-mode,Fail
spec@!opengl 1.1@polygon-mode-facing,Fail
spec@!opengl 1.1@polygon-mode-offset,Fail

6
src/gallium/frontends/lavapipe/lvp_execute.c
View file

@ -329,8 +329,14 @@ static void emit_state(struct rendering_state *state)
assert(offsetof(struct pipe_rasterizer_state, offset_clamp) - offsetof(struct pipe_rasterizer_state, offset_units) == sizeof(float) * 2);
if (state->depth_bias.enabled) {
memcpy(&state->rs_state.offset_units, &state->depth_bias, sizeof(float) * 3);
state->rs_state.offset_tri = true;
state->rs_state.offset_line = true;
state->rs_state.offset_point = true;
} else {
memset(&state->rs_state.offset_units, 0, sizeof(float) * 3);
state->rs_state.offset_tri = false;
state->rs_state.offset_line = false;
state->rs_state.offset_point = false;
}
cso_set_rasterizer(state->cso, &state->rs_state);
state->rs_dirty = false;