fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-06 08:50:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tu/lrz: Disable LRZ if RP writes depth but doesn't set on GPU dir
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
If the render pass writes depth (with direction) but doesn't set
direction on the GPU, the LRZ buffer cannot be used in subsequent
render passes because the direction information is lost.

Fixes rendering in "Elite Dangerous" game.

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34577>
This commit is contained in:
Danylo Piliaiev 2025-04-17 14:13:02 +02:00 • committed by Marge Bot
parent f903397874
commit 969820e7fe
3 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/freedreno/vulkan/tu_cmd_buffer.cc
View file

@ -4960,6 +4960,12 @@ tu_CmdExecuteCommands(VkCommandBuffer commandBuffer,
*/
if (!secondary->state.lrz.valid)
cmd->state.lrz.valid = false;
if (secondary->state.lrz.gpu_dir_set)
cmd->state.lrz.gpu_dir_set = true;
if (cmd->state.lrz.prev_direction == TU_LRZ_UNKNOWN &&
secondary->state.lrz.prev_direction != TU_LRZ_UNKNOWN)
cmd->state.lrz.prev_direction =
secondary->state.lrz.prev_direction;
tu_clone_trace(cmd, &cmd->draw_cs, &secondary->trace);
tu_render_pass_state_merge(&cmd->state.rp, &secondary->state.rp);

19
src/freedreno/vulkan/tu_lrz.cc
View file

@ -504,8 +504,18 @@ tu_lrz_tiling_end(struct tu_cmd_buffer *cmd, struct tu_cs *cs)
/* If we haven't disabled LRZ during renderpass, we need to disable it here
* for next renderpass to not use invalid LRZ values.
*/
if (cmd->state.lrz.gpu_dir_tracking && cmd->state.lrz.valid_at_start &&
!cmd->state.lrz.valid) {
bool disable_for_next_rp = cmd->state.lrz.valid_at_start &&
!cmd->state.lrz.valid;
/* If the render pass writes depth (with direction) but doesn't set
* direction on the GPU, the LRZ buffer cannot be used in subsequent
* render passes because the direction information is lost.
*/
if (!cmd->state.lrz.gpu_dir_set &&
cmd->state.lrz.prev_direction != TU_LRZ_UNKNOWN) {
disable_for_next_rp = true;
}
if (cmd->state.lrz.gpu_dir_tracking && disable_for_next_rp) {
tu6_write_lrz_reg(cmd, cs, A6XX_GRAS_LRZ_DEPTH_VIEW(
.base_layer = 0b11111111111,
.layer_count = 0b11111111111,
@ -962,6 +972,11 @@ tu6_calculate_lrz_state(struct tu_cmd_buffer *cmd,
if (!cmd->state.lrz.enabled)
memset(&gras_lrz_cntl, 0, sizeof(gras_lrz_cntl));
if (cmd->state.lrz.enabled && gras_lrz_cntl.lrz_write &&
cmd->state.lrz.prev_direction != TU_LRZ_UNKNOWN) {
cmd->state.lrz.gpu_dir_set = true;
}
return gras_lrz_cntl;
}

1
src/freedreno/vulkan/tu_lrz.h
View file

@ -45,6 +45,7 @@ struct tu_lrz_state
bool gpu_dir_tracking : 1;
/* Continue using old LRZ state (LOAD_OP_LOAD of depth) */
bool reuse_previous_state : 1;
bool gpu_dir_set : 1;
enum tu_lrz_direction prev_direction;
};