fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 05:18:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

intel/isl: Allow multi-sample on depth aux usage (xe2)

Browse source 
The restriction on depth aux mode is gone on Xe2 in spec.

Fix: piglit
arb_post_depth_coverage-multisampling -auto -fbo
isl_surface_state.c:723: isl_gfx20_surf_fill_state_s:
Assertion `info->surf->samples == 1' failed.

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29274>
This commit is contained in:
Jianxun Zhang 2024-05-13 21:25:05 -07:00 • committed by Marge Bot
parent bd6ace73f3
commit 9654aa4c31
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/intel/isl/isl_surface_state.c
View file

@ -718,8 +718,13 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
* ISL_MSAA_LAYOUT_INTERLEAVED which is incompatible with MCS
* compression, this means that we can't even specify MSAA depth CCS
* in RENDER_SURFACE_STATE::AuxiliarySurfaceMode.
*
* On Xe2+, the above restriction is not mentioned in the
* RENDER_SURFACE_STATE::AuxiliarySurfaceMode.
*
* Bspec 57023 (r58975)
*/
assert(info->surf->samples == 1);
assert(GFX_VER >= 20 || info->surf->samples == 1);
/* Prior to Gfx12, the dimension must not be 3D */
if (info->aux_usage == ISL_AUX_USAGE_HIZ)