fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-20 07:20:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

i965/fs: don't propagate cmod when the exec sizes differ

Browse source 
This can happen when the source of the compare was split by the SIMD
lowering pass. Potentially, we could allow the case where the exec size
of scan_inst is larger, and scan_inst has the right quarter selected,
but doing that seems a little more risky.

v2: Merge the bail condition into the the previous if/break block (Matt)

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
This commit is contained in:
Connor Abbott 2015-08-11 16:16:42 -07:00 • committed by Iago Toral Quiroga
parent 70171a9c89
commit 95ac3b1dae
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/mesa/drivers/dri/i965/brw_fs_cmod_propagation.cpp
View file

@ -90,7 +90,8 @@ opt_cmod_propagation_local(bblock_t *block)
foreach_inst_in_block_reverse_starting_from(fs_inst, scan_inst, inst) { foreach_inst_in_block_reverse_starting_from(fs_inst, scan_inst, inst) {
if (scan_inst->overwrites_reg(inst->src[0])) { if (scan_inst->overwrites_reg(inst->src[0])) {
if (scan_inst->is_partial_write() || if (scan_inst->is_partial_write() ||
scan_inst->dst.reg_offset != inst->src[0].reg_offset) scan_inst->dst.reg_offset != inst->src[0].reg_offset ||
scan_inst->exec_size != inst->exec_size)
break; break;
/* CMP's result is the same regardless of dest type. */ /* CMP's result is the same regardless of dest type. */