From 953b02e2d06809c4fa21feec28bfa39c507a8842 Mon Sep 17 00:00:00 2001 From: Zan Dobersek Date: Wed, 4 Feb 2026 17:27:45 +0100 Subject: [PATCH] tu/kgsl: wait-only submit handling should not ignore sparse bind commands Commit cf4bd2e412 added a fast path for handling no-command submits to accommodate a kernel behavior quirk. Sparse support was complete before that change but landed afterwards, leaving sparse submits that don't have command buffers but do have sparse bind commands to take that fast path, leaving the bind commands unhandled. The condition for the fast path is fixed to address that. Signed-off-by: Zan Dobersek Fixes: 71ef46717cd ("tu/kgsl: Add support for sparse binding") (cherry picked from commit 5b33ee9f0b772af3b5b3855ea339b74c70f4c6ce) Part-of: --- .pick_status.json | 2 +- src/freedreno/vulkan/tu_knl_kgsl.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 9374f26bfa0..634ba708a00 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -934,7 +934,7 @@ "description": "tu/kgsl: wait-only submit handling should not ignore sparse bind commands", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "71ef46717cd091f0a12a12cf5a8da3ec8a6fe96a", "notes": null diff --git a/src/freedreno/vulkan/tu_knl_kgsl.cc b/src/freedreno/vulkan/tu_knl_kgsl.cc index eb19ef6753b..e123249be1c 100644 --- a/src/freedreno/vulkan/tu_knl_kgsl.cc +++ b/src/freedreno/vulkan/tu_knl_kgsl.cc @@ -1328,7 +1328,7 @@ kgsl_queue_submit(struct tu_queue *queue, void *_submit, uint64_t start_ts = tu_perfetto_begin_submit(); #endif - if (submit->commands.size == 0) { + if (submit->commands.size == 0 && submit->bind_cmds.size == 0) { /* This handles the case where we have a wait and no commands to submit. * It is necessary to handle this case separately as the kernel will not * advance the GPU timeline if a submit with no commands is made, even