From 94c7ccbaa3540e384571c7438f48ca06cbac9cc6 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 6 Jun 2026 20:26:13 -0700 Subject: [PATCH] radeonsi: remove duplicate '.bpp' initializer in si_sdma_copy_image Compiling with clang produces a -Winitializer-overrides warning: src/gallium/drivers/radeonsi/si_sdma_copy_image.c:217:17: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] The surf_src and surf_dst ac_sdma_surf initializers each set '.bpp = bpp' twice: once next to the other scalar fields and once again after the nested '.offset' initializer. The values are identical, so behavior is unchanged, but the duplicate field initializer is redundant. Drop the second one. Fixes: e6e305988c76 ("ac,radv,radeonsi: merge tiled/linear surfaces into one struct") Assisted-by: Claude Code (Claude Opus 4.8) Signed-off-by: Vinson Lee Reviewed-by: Benjamin Cheng Reviewed-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Samuel Pitoiset Part-of: --- src/gallium/drivers/radeonsi/si_sdma_copy_image.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_sdma_copy_image.c b/src/gallium/drivers/radeonsi/si_sdma_copy_image.c index a1796105829..d22c6ad3dea 100644 --- a/src/gallium/drivers/radeonsi/si_sdma_copy_image.c +++ b/src/gallium/drivers/radeonsi/si_sdma_copy_image.c @@ -214,7 +214,6 @@ bool cik_sdma_copy_texture(struct si_context *sctx, struct si_texture *sdst, str .y = 0, .z = 0, }, - .bpp = bpp, .pitch = src_pitch, .slice_pitch = src_slice_pitch, }; @@ -230,7 +229,6 @@ bool cik_sdma_copy_texture(struct si_context *sctx, struct si_texture *sdst, str .y = 0, .z = 0, }, - .bpp = bpp, .pitch = dst_pitch, .slice_pitch = dst_slice_pitch, };