From 944c8907ba80866cd52326cc7fb043df0d2c2e90 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Wed, 16 Jun 2021 16:27:04 -0400 Subject: [PATCH] pan/bi: Don't call useless NIR passes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cargo culted from the Midgard compiler. nir_move_vec_src_uses_to_dest is intended for vec4 backends, which does not apply to Bifrost. nir_lower_locals_to_regs runs much earlier in the compiler and is a no-op here. total instructions in shared programs: 107252 -> 107242 (<.01%) instructions in affected programs: 2403 -> 2393 (-0.42%) helped: 10 HURT: 0 helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.33% max: 0.57% x̄: 0.43% x̃: 0.42% 95% mean confidence interval for instructions value: -1.00 -1.00 95% mean confidence interval for instructions %-change: -0.49% -0.37% Instructions are helped. total tuples in shared programs: 89664 -> 89664 (0.00%) tuples in affected programs: 333 -> 333 (0.00%) helped: 1 HURT: 1 helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.52% max: 0.52% x̄: 0.52% x̃: 0.52% HURT stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 HURT stats (rel) min: 0.70% max: 0.70% x̄: 0.70% x̃: 0.70% total cycles in shared programs: 8103.88 -> 8103.79 (<.01%) cycles in affected programs: 29.42 -> 29.33 (-0.28%) helped: 3 HURT: 1 helped stats (abs) min: 0.041665999999999315 max: 0.04166700000000034 x̄: 0.04 x̃: 0 helped stats (rel) min: 0.49% max: 0.55% x̄: 0.53% x̃: 0.54% HURT stats (abs) min: 0.04166700000000034 max: 0.04166700000000034 x̄: 0.04 x̃: 0 HURT stats (rel) min: 0.74% max: 0.74% x̄: 0.74% x̃: 0.74% 95% mean confidence interval for cycles value: -0.09 0.05 95% mean confidence interval for cycles %-change: -1.22% 0.80% Inconclusive result (value mean confidence interval includes 0). total arith in shared programs: 3376.42 -> 3376.33 (<.01%) arith in affected programs: 29.42 -> 29.33 (-0.28%) helped: 3 HURT: 1 helped stats (abs) min: 0.041665999999999315 max: 0.04166700000000034 x̄: 0.04 x̃: 0 helped stats (rel) min: 0.49% max: 0.55% x̄: 0.53% x̃: 0.54% HURT stats (abs) min: 0.04166700000000034 max: 0.04166700000000034 x̄: 0.04 x̃: 0 HURT stats (rel) min: 0.74% max: 0.74% x̄: 0.74% x̃: 0.74% 95% mean confidence interval for arith value: -0.09 0.05 95% mean confidence interval for arith %-change: -1.22% 0.80% Inconclusive result (value mean confidence interval includes 0). total quadwords in shared programs: 79681 -> 79681 (0.00%) quadwords in affected programs: 283 -> 283 (0.00%) helped: 1 HURT: 1 helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.62% max: 0.62% x̄: 0.62% x̃: 0.62% HURT stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 HURT stats (rel) min: 0.82% max: 0.82% x̄: 0.82% x̃: 0.82% total threads in shared programs: 2226 -> 2227 (0.04%) threads in affected programs: 1 -> 2 (100.00%) helped: 1 HURT: 0 Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/bifrost_compile.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/panfrost/bifrost/bifrost_compile.c b/src/panfrost/bifrost/bifrost_compile.c index e9163f92551..047ab4fabf9 100644 --- a/src/panfrost/bifrost/bifrost_compile.c +++ b/src/panfrost/bifrost/bifrost_compile.c @@ -3497,9 +3497,6 @@ bi_optimize_nir(nir_shader *nir, unsigned gpu_id, bool is_blend) nir_invalidate_divergence, nir_metadata_all, NULL); } - /* Take us out of SSA */ - NIR_PASS(progress, nir, nir_lower_locals_to_regs); - NIR_PASS(progress, nir, nir_move_vec_src_uses_to_dest); NIR_PASS(progress, nir, nir_convert_from_ssa, true); }