fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 13:58:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

v3dv/bo: reduce DEFAULT_MAX_BO_CACHE_SIZE to 64

Browse source 
The best way to tune this value is to test Vulkan
applications. Current somewhat big value (512), was obtained by
testing only vkQuake2. Additionally at that time the bo cache was the
first performance oriented improvement we implemented.

After more improvements were included, and retested with more
applications, the conclusion is that we can reduce the value. More
info on the issue that closes.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7090

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18398>
This commit is contained in:
Alejandro Piñeiro 2022-08-12 03:03:15 +02:00 • committed by Marge Bot
parent a68e2b810c
commit 944b08e597
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/broadcom/vulkan/v3dv_bo.c
View file

@ -31,11 +31,12 @@
/* Default max size of the bo cache, in MB.
*
* FIXME: we got this value when testing some apps using the rpi4 with 4GB,
* but it should depend on the total amount of RAM. But for that we would need
* to test on real hw with different amount of RAM. Using this value for now.
* This value comes from testing different Vulkan application. Greater values
* didn't get any further performance benefit. This looks somewhat small, but
* from testing those applications, the main consumer of the bo cache are
* the bos used for the CLs, that are usually small.
*/
#define DEFAULT_MAX_BO_CACHE_SIZE 512
#define DEFAULT_MAX_BO_CACHE_SIZE 64
/* Discarded to use a V3D_DEBUG for this, as it would mean adding a run-time
* check for most of the calls