fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-15 09:30:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

pan/midgard: Reorder bits check to fix 8-bit masks

Browse source 
Coverity.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig 2019-08-21 09:17:03 -07:00
parent 6189274f57
commit 91a5b2657d
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/panfrost/midgard/disassemble.c
View file

@ -411,6 +411,11 @@ print_mask_vec16(uint8_t mask, midgard_dest_override override)
static void
print_mask(uint8_t mask, unsigned bits, midgard_dest_override override)
{
if (bits == 8) {
print_mask_vec16(mask, override);
return;
}
if (bits < 16) {
/* Shouldn't happen but with junk / out-of-spec shaders it
* would cause an infinite loop */
@ -419,11 +424,6 @@ print_mask(uint8_t mask, unsigned bits, midgard_dest_override override)
return;
}
if (bits == 8) {
print_mask_vec16(mask, override);
return;
}
/* Skip 'complete' masks */
if (bits >= 32 && mask == 0xFF) return;