From 90dbbc69bb79c4dae7e9b802409090e18f952721 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Thu, 16 Jan 2025 02:58:01 -0800 Subject: [PATCH] brw: Use BAD_FILE instead of ARF null for second send payload A number of places emit monolithic sends, where the second payload is empty. Some places were using a BAD_FILE register, while others were specifying the hardware ARF null register. Switch to BAD_FILE for consistency - this is usually what we do for "source isn't present". Reviewed-by: Lionel Landwerlin Reviewed-by: Caio Oliveira Part-of: --- src/intel/compiler/brw_lower_logical_sends.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/compiler/brw_lower_logical_sends.cpp b/src/intel/compiler/brw_lower_logical_sends.cpp index 2292be34ccb..83b968cd1c6 100644 --- a/src/intel/compiler/brw_lower_logical_sends.cpp +++ b/src/intel/compiler/brw_lower_logical_sends.cpp @@ -70,7 +70,7 @@ lower_urb_read_logical_send(const brw_builder &bld, brw_inst *inst) inst->src[0] = brw_imm_ud(0); /* desc */ inst->src[1] = brw_imm_ud(0); /* ex_desc */ inst->src[2] = payload; - inst->src[3] = brw_null_reg(); + inst->src[3] = brw_reg(); } static void @@ -129,7 +129,7 @@ lower_urb_read_logical_send_xe2(const brw_builder &bld, brw_inst *inst) inst->src[1] = brw_imm_ud(0); inst->src[2] = payload; - inst->src[3] = brw_null_reg(); + inst->src[3] = brw_reg(); } static void @@ -186,7 +186,7 @@ lower_urb_write_logical_send(const brw_builder &bld, brw_inst *inst) inst->src[0] = brw_imm_ud(0); /* desc */ inst->src[1] = brw_imm_ud(0); /* ex_desc */ inst->src[2] = payload; - inst->src[3] = brw_null_reg(); + inst->src[3] = brw_reg(); } static void