diff --git a/.pick_status.json b/.pick_status.json index 4f0e3bef45c..055eaae809d 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -12829,7 +12829,7 @@ "description": "pan/bi: Don't allow ATEST to take a temporary", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/panfrost/bifrost/bi_schedule.c b/src/panfrost/bifrost/bi_schedule.c index 8271beb2b64..e30b10fb8ad 100644 --- a/src/panfrost/bifrost/bi_schedule.c +++ b/src/panfrost/bifrost/bi_schedule.c @@ -630,6 +630,15 @@ bi_reads_temps(bi_instr *ins, unsigned src) case BI_OPCODE_CLPER_I32: case BI_OPCODE_CLPER_OLD_I32: return src != 0; + + /* ATEST isn't supposed to be restricted, but in practice it always + * wants to source its coverage mask input (source 0) from register 60, + * which won't work properly if we put the input in a temp. This + * requires workarounds in both RA and clause scheduling. + */ + case BI_OPCODE_ATEST: + return src != 0; + case BI_OPCODE_IMULD: return false; default: