fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-15 07:20:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

ilo: fix fence reference counting

Browse source 
The old code was complicated, and was wrong when *ptr is NULL.
This commit is contained in:
Chia-I Wu 2014-07-08 14:03:17 +08:00
parent bbefb15e01
commit 8ff16111ee
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/gallium/drivers/ilo/ilo_screen.c
View file

@ -529,26 +529,23 @@ ilo_fence_reference(struct pipe_screen *screen,
struct pipe_fence_handle **p,
struct pipe_fence_handle *f)
{
struct ilo_fence **ptr = (struct ilo_fence **) p;
struct ilo_fence *fence = ilo_fence(f);
struct ilo_fence *old;
if (!ptr) {
/* still need to reference fence */
if (fence)
pipe_reference(NULL, &fence->reference);
return;
if (likely(p)) {
old = ilo_fence(*p);
*p = f;
}
else {
old = NULL;
}
/* reference fence and dereference the one pointed to by ptr */
if (*ptr && pipe_reference(&(*ptr)->reference, &fence->reference)) {
struct ilo_fence *old = *ptr;
STATIC_ASSERT(&((struct ilo_fence *) NULL)->reference == NULL);
if (pipe_reference(&old->reference, &fence->reference)) {
if (old->bo)
intel_bo_unreference(old->bo);
FREE(old);
}
*ptr = fence;
}
static boolean