fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

os: Fix open result check.

Browse source 
Fix defect reported by Coverity Scan.

Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: f is passed to a parameter that cannot be negative.

CID: 1364709
Fixes: 13fa051356 ("auxiliary/os: add new os_get_command_line() function")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7344>
(cherry picked from commit b2a21febe0)
This commit is contained in:
Vinson Lee 2020-10-27 16:21:11 -07:00 • committed by Dylan Baker
parent 9f3d7d54d8
commit 8f766d37eb
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -5539,7 +5539,7 @@
"description": "os: Fix open result check.",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "13fa0513569d0145487e12f3bc3aa10bc51088f7"
},

2
src/gallium/auxiliary/os/os_process.c
View file

@ -122,7 +122,7 @@ os_get_command_line(char *cmdline, size_t size)
}
#elif defined(PIPE_OS_LINUX)
int f = open("/proc/self/cmdline", O_RDONLY);
if (f) {
if (f != -1) {
const int n = read(f, cmdline, size - 1);
int i;
assert(n < size);