fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 13:58:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

radv: do not allow to capture SQTT on the compute queue

Browse source 
This currently hangs and I don't know why. It looks better to
print a message instead of hanging the whole system.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9097>
This commit is contained in:
Samuel Pitoiset 2021-02-17 11:12:13 +01:00 • committed by Marge Bot
parent 6d8516bd74
commit 8e97fc3a29
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/amd/vulkan/layers/radv_sqtt_layer.c
View file

@ -346,6 +346,15 @@ radv_handle_thread_trace(VkQueue _queue)
#endif
if (frame_trigger || file_trigger) {
/* FIXME: SQTT on compute hangs. */
if (queue->queue_family_index == RADV_QUEUE_COMPUTE) {
fprintf(stderr, "RADV: Capturing a SQTT trace on the compute "
"queue is currently broken and might hang! "
"Please, disable presenting on compute if "
"you can.\n");
return;
}
radv_begin_thread_trace(queue);
assert(!thread_trace_enabled);
thread_trace_enabled = true;