From 8cc4e0b0c4faf3a09d61fa5376ddbde1dcb491c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tapani=20P=C3=A4lli?= Date: Tue, 28 Sep 2021 13:20:53 +0300 Subject: [PATCH] anv: remove a format assert when setting up attachments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There are exceptions in spec where the framebuffer image format and format given for render pass attachment may differ. This happens in particular when subpass has resolve attachment that might resolve only depth from a combined depth+stencil format. There the formats do not need to match but be 'compatible' with each other. As example using VK_FORMAT_D32_SFLOAT format is considered compatible when actual framebuffer format is VK_FORMAT_D32_SFLOAT_S8_UINT. Signed-off-by: Tapani Pälli Reviewed-by: Sagar Ghuge Part-of: --- src/intel/vulkan/genX_cmd_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index a69236baa9b..75c33c38cbe 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -1614,7 +1614,6 @@ genX(cmd_buffer_setup_attachments)(struct anv_cmd_buffer *cmd_buffer, att_state->clear_value = begin->pClearValues[i]; struct anv_image_view *iview = state->attachments[i].image_view; - anv_assert(iview->vk.format == pass_att->format); const uint32_t num_layers = iview->planes[0].isl.array_len; att_state->pending_clear_views = (1 << num_layers) - 1;