From 8cb89853b8f9993febb848ac83c5f6cf85aec11a Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Fri, 17 Apr 2026 15:31:16 +0200 Subject: [PATCH] panvk: do not enable extension without required feature The Vulkan spec states that if VK_ARM_shader_core_builtins is supported, shaderCoreBuiltins is a required feature. So let's not enable that extension unless we can... Fixes: dff1d91c64e ("panvk: Enable VK_ARM_shader_core_builtins") Reviewed-by: Daniel Stone Part-of: --- docs/features.txt | 2 +- src/panfrost/vulkan/panvk_vX_physical_device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index f50abe14b3d..dd012e157c7 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -722,7 +722,7 @@ Khronos extensions that are not part of any Vulkan version: VK_ANDROID_native_buffer DONE (anv, lvp, panvk, radv, tu, v3dv, vn) VK_ARM_rasterization_order_attachment_access DONE (lvp, tu, vn) VK_ARM_scheduling_controls DONE (panvk/v10+) - VK_ARM_shader_core_builtins DONE (panvk) + VK_ARM_shader_core_builtins DONE (panvk/v9+) VK_ARM_shader_core_properties DONE (panvk/v10+) VK_GOOGLE_decorate_string DONE (anv, hasvk, hk, kk, lvp, nvk, panvk, radv, tu, vn) VK_GOOGLE_hlsl_functionality1 DONE (anv, hasvk, hk, kk, lvp, nvk, panvk, radv, tu, vn) diff --git a/src/panfrost/vulkan/panvk_vX_physical_device.c b/src/panfrost/vulkan/panvk_vX_physical_device.c index 54da96d0df4..f1b63c0ef18 100644 --- a/src/panfrost/vulkan/panvk_vX_physical_device.c +++ b/src/panfrost/vulkan/panvk_vX_physical_device.c @@ -222,7 +222,7 @@ panvk_per_arch(get_physical_device_extensions)( .VALVE_mutable_descriptor_type = PAN_ARCH >= 9, - .ARM_shader_core_builtins = true, + .ARM_shader_core_builtins = PAN_ARCH >= 9, .ARM_shader_core_properties = has_vk1_1, .ARM_scheduling_controls = PAN_ARCH >= 10, };