fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 04:38:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nak/spill_values: Don't assume no trivial phis

Browse source 
Thanks to LCSSA, we can absolutely have phis with only one source and we
need to handle those in spilling.  Fortunately, there's nothing really
special about that case.  I was just prematurely optimizing.

Fixes: bcad2add47 ("nak: Add a spilling pass")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28084>
This commit is contained in:
Faith Ekstrand 2024-07-23 14:13:12 -05:00 • committed by Marge Bot
parent 305bf503e7
commit 8bf3213a54
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/nouveau/compiler/nak/spill_values.rs
View file

@ -899,14 +899,6 @@ fn spill_values<S: Spill>(
}
let s_idx = succ[0];
// If blocks[p_idx] is the unique predecessor of blocks[s_idx] then the
// spill/fill sets for blocks[s_idx] are just those from blocks[p_idx],
// filtered for liveness and there is no phi source. There's nothing
// for us to do here.
if blocks.pred_indices(s_idx).len() == 1 {
continue;
}
let pb = &mut blocks[p_idx];
let p_out = &ssa_state_out[p_idx];
let s_in = &ssa_state_in[s_idx];