fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 17:48:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

vk: Return anv_image_view_info by value

Browse source 
The struct is only 2 bytes. Returning it on the stack is better than
returning a reference into the ELF .data segment.
This commit is contained in:
Chad Versace 2015-10-05 13:22:44 -07:00
parent 4ffb4549e0
commit 8bf021cf3d
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/vulkan/anv_image.c
View file

@ -61,10 +61,10 @@ anv_image_view_info_table[] = {
#undef INFO #undef INFO
}; };
const struct anv_image_view_info * struct anv_image_view_info
anv_image_view_info_for_vk_image_view_type(VkImageViewType type) anv_image_view_info_for_vk_image_view_type(VkImageViewType type)
{ {
return &anv_image_view_info_table[type]; return anv_image_view_info_table[type];
} }
static const struct anv_surf_type_limits { static const struct anv_surf_type_limits {

2
src/vulkan/anv_private.h
View file

@ -1154,7 +1154,7 @@ struct anv_image_view_info {
bool is_cube:1; /**< RENDER_SURFACE_STATE.CubeFaceEnable* */ bool is_cube:1; /**< RENDER_SURFACE_STATE.CubeFaceEnable* */
}; };
const struct anv_image_view_info * struct anv_image_view_info
anv_image_view_info_for_vk_image_view_type(VkImageViewType type); anv_image_view_info_for_vk_image_view_type(VkImageViewType type);
/** /**

4
src/vulkan/gen7_state.c
View file

@ -279,7 +279,7 @@ gen7_image_view_init(struct anv_image_view *iview,
const struct anv_format *format = const struct anv_format *format =
anv_format_for_vk_format(pCreateInfo->format); anv_format_for_vk_format(pCreateInfo->format);
const struct anv_image_view_info *view_type_info = const struct anv_image_view_info view_type_info =
anv_image_view_info_for_vk_image_view_type(pCreateInfo->viewType); anv_image_view_info_for_vk_image_view_type(pCreateInfo->viewType);
if (pCreateInfo->viewType != VK_IMAGE_VIEW_TYPE_2D) if (pCreateInfo->viewType != VK_IMAGE_VIEW_TYPE_2D)
@ -303,7 +303,7 @@ gen7_image_view_init(struct anv_image_view *iview,
} }
struct GEN7_RENDER_SURFACE_STATE surface_state = { struct GEN7_RENDER_SURFACE_STATE surface_state = {
.SurfaceType = view_type_info->surface_type, .SurfaceType = view_type_info.surface_type,
.SurfaceArray = image->array_size > 1, .SurfaceArray = image->array_size > 1,
.SurfaceFormat = format->surface_format, .SurfaceFormat = format->surface_format,
.SurfaceVerticalAlignment = anv_valign[surface->v_align], .SurfaceVerticalAlignment = anv_valign[surface->v_align],

4
src/vulkan/gen8_state.c
View file

@ -158,7 +158,7 @@ gen8_image_view_init(struct anv_image_view *iview,
const struct anv_format *format_info = const struct anv_format *format_info =
anv_format_for_vk_format(pCreateInfo->format); anv_format_for_vk_format(pCreateInfo->format);
const struct anv_image_view_info *view_type_info = const struct anv_image_view_info view_type_info =
anv_image_view_info_for_vk_image_view_type(pCreateInfo->viewType); anv_image_view_info_for_vk_image_view_type(pCreateInfo->viewType);
view->bo = image->bo; view->bo = image->bo;
@ -220,7 +220,7 @@ gen8_image_view_init(struct anv_image_view *iview,
}; };
struct GEN8_RENDER_SURFACE_STATE surface_state = { struct GEN8_RENDER_SURFACE_STATE surface_state = {
.SurfaceType = view_type_info->surface_type, .SurfaceType = view_type_info.surface_type,
.SurfaceArray = image->array_size > 1, .SurfaceArray = image->array_size > 1,
.SurfaceFormat = format_info->surface_format, .SurfaceFormat = format_info->surface_format,
.SurfaceVerticalAlignment = anv_valign[surface->v_align], .SurfaceVerticalAlignment = anv_valign[surface->v_align],