fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-12 09:00:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

brw/validate: Eliminate duplicate integer multiply validation

Browse source 
I think two MRs must have crossed in the mail so to speak. Keep Caio's
formatting and error message, and keep my PRM quote.

Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40226>
This commit is contained in:
Ian Romanick 2026-03-03 08:06:59 -08:00 • committed by Marge Bot
parent 64c60582b5
commit 8a6de2d973
1 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/intel/compiler/brw/brw_eu_validate.c
View file

@ -1835,6 +1835,13 @@ instruction_restrictions(const struct brw_isa_info *isa,
brw_type_is_int(src1_type)),
"MUL can't mix floats and integer sources.");
/* Page 971 (page 987 of the PDF), section "Accumulator
* Restrictions," of the Broadwell PRM volume 7 says:
*
* Integer source operands cannot be accumulators.
*
* The Skylake and Ice Lake PRMs contain the same text.
*/
ERROR_IF((brw_type_is_int(src0_type) && src0_is_acc(inst)) ||
(brw_type_is_int(src1_type) && src1_is_acc(inst)),
"In MUL, Integer source operands cannot be accumulators.");
@ -1853,19 +1860,6 @@ instruction_restrictions(const struct brw_isa_info *isa,
"When multiplying a DW and any lower precision integer, the "
"DW operand must be src0.");
/* Page 971 (page 987 of the PDF), section "Accumulator
* Restrictions," of the Broadwell PRM volume 7 says:
*
* Integer source operands cannot be accumulators.
*
* The Skylake and Ice Lake PRMs contain the same text.
*/
ERROR_IF((src0_is_acc(inst) &&
brw_type_is_int(src0_type)) ||
(src1_is_acc(inst) &&
brw_type_is_int(src1_type)),
"Integer source operands cannot be accumulators.");
/* Page 935 (page 951 of the PDF) of the Ice Lake PRM volume 2a says:
*
* When multiplying integer data types, if one of the sources is a