fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-29 18:50:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

isl: make Wa_1806565034 conditional to non robust access

Browse source 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20280>
This commit is contained in:
Lionel Landwerlin 2022-12-12 15:30:40 +02:00 • committed by Marge Bot
parent 6a3179c5a9
commit 89a550a37b
2 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/intel/isl/isl.h
View file

@ -1707,6 +1707,13 @@ struct isl_surf_fill_state_info {
/* Intra-tile offset */
uint16_t x_offset_sa, y_offset_sa;
/**
* Robust image access enabled
*
* This is used to turn off a performance workaround.
*/
bool robust_image_access;
};
struct isl_buffer_fill_state_info {

11
src/intel/isl/isl_surface_state.c
View file

@ -362,9 +362,16 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
}
#if GFX_VER >= 12
/* Wa_1806565034: Only set SurfaceArray if arrayed surface is > 1. */
/* Wa_1806565034:
*
* "Only set SurfaceArray if arrayed surface is > 1."
*
* Since this is a performance workaround, we only enable it when robust
* image access is disabled. Otherwise layered robust access is not
* specification compliant.
*/
s.SurfaceArray = info->surf->dim != ISL_SURF_DIM_3D &&
info->view->array_len > 1;
(info->robust_image_access || info->view->array_len > 1);
#elif GFX_VER >= 7
s.SurfaceArray = info->surf->dim != ISL_SURF_DIM_3D;
#endif