diff --git a/.pick_status.json b/.pick_status.json index 9a4950b4485..581b2a63d9c 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -211,7 +211,7 @@ "description": "aco: disallow SGPRs on DPP instructions", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": null }, diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp index 590749ccf5b..42f50cae8fc 100644 --- a/src/amd/compiler/aco_optimizer.cpp +++ b/src/amd/compiler/aco_optimizer.cpp @@ -715,7 +715,7 @@ bool pseudo_propagate_temp(opt_ctx& ctx, aco_ptr& instr, bool can_apply_sgprs(opt_ctx& ctx, aco_ptr& instr) { - if (instr->isSDWA() && ctx.program->chip_class < GFX9) + if ((instr->isSDWA() && ctx.program->chip_class < GFX9) || instr->isDPP()) return false; return instr->opcode != aco_opcode::v_readfirstlane_b32 && instr->opcode != aco_opcode::v_readlane_b32 && diff --git a/src/amd/compiler/aco_validate.cpp b/src/amd/compiler/aco_validate.cpp index 15db1799e4d..80fb7f7a0ce 100644 --- a/src/amd/compiler/aco_validate.cpp +++ b/src/amd/compiler/aco_validate.cpp @@ -253,6 +253,8 @@ bool validate_ir(Program* program) uint32_t scalar_mask = instr->isVOP3() || instr->isVOP3P() ? 0x7 : 0x5; if (instr->isSDWA()) scalar_mask = program->chip_class >= GFX9 ? 0x7 : 0x4; + else if (instr->isDPP()) + scalar_mask = 0x0; if (instr->isVOPC() || instr->opcode == aco_opcode::v_readfirstlane_b32 ||