fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-15 23:50:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

st/mesa: Set gl_config.floatMode based on color_format

Browse source 
Sets the float color component type in st_visual_to_context_mode()
ensuring float color values are not clamped.
Fixes dEQP-EGL.functional.wide_color.window_fp16_default_colorspace on
asahi, iris and most likely every other driver having it marked as fail
or flake.

Closes: mesa/mesa#9276

Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23914>
(cherry picked from commit fd4d0e1cc2)
This commit is contained in:
Janne Grunau 2023-06-28 21:09:50 +02:00 • committed by Eric Engestrom
parent 5217a77d6d
commit 8841b3ab06
9 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -4540,7 +4540,7 @@
"description": "st/mesa: Set gl_config.floatMode based on color_format",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

1
src/broadcom/ci/broadcom-rpi4-fails.txt
View file

@ -338,7 +338,6 @@ spec@!opengl 2.0@max-samplers,Fail
spec@!opengl 2.0@max-samplers border,Fail
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
spec@!opengl 1.1@line-smooth-stipple,Fail

1
src/freedreno/ci/freedreno-a618-fails.txt
View file

@ -336,7 +336,6 @@ spill-dEQP-VK.subgroups.ballot_broadcast.compute.subgroupbroadcast_bool_required
# Failing (Color test failed) since wayland platform was enabled in arm builds
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
# skqp failure:
# SRGBReadWritePixels FAILED (7 errors)

1
src/freedreno/ci/freedreno-a630-fails.txt
View file

@ -346,7 +346,6 @@ wayland-dEQP-EGL.functional.wide_color.pbuffer_888_colorspace_default,Fail
# Failing (Color test failed) since wayland platform was enabled in arm builds
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
# skqp failure:
# SRGBReadWritePixels FAILED (7 errors)

2
src/intel/ci/iris-amly-fails.txt
View file

@ -6,8 +6,6 @@
wayland-dEQP-EGL.functional.wide_color.pbuffer_888_colorspace_default,Fail
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
# New CTS failures in 1.3.5.0
KHR-GL46.polygon_offset_clamp.PolygonOffsetClampMinMax,Fail
KHR-GL46.polygon_offset_clamp.PolygonOffsetClampZeroInfinity,Fail

1
src/intel/ci/iris-apl-fails.txt
View file

@ -11,4 +11,3 @@ KHR-GL46.polygon_offset_clamp.PolygonOffsetClampZeroInfinity,Fail
# after enabling wayland in x86_64 mesa build
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail

3
src/intel/ci/iris-apl-flakes.txt
View file

@ -21,6 +21,3 @@ dEQP-EGL.functional.sharing.gles2.multithread.simple.buffers.buffersubdata_rende
# 2022-05-05 18:40:38.338548: [ 830.144153] i915 0000:00:02.0: [drm] GPU HANG: ecode 9:1:87d79ffe, in deqp-gles31 [2571]
dEQP-GLES31.functional.primitive_bounding_box.clear.scissored_clear_with_triangles
dEQP-GLES31.functional.primitive_bounding_box.clear.scissored_clear_with_triangles_per_primitive_bbox
# Since Wayland was enabled on x86-64, this test flakes occasionally.
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace

1
src/mesa/state_tracker/st_manager.c
View file

@ -559,6 +559,7 @@ st_visual_to_context_mode(const struct st_visual *visual,
mode->rgbBits = mode->redBits +
mode->greenBits + mode->blueBits + mode->alphaBits;
mode->sRGBCapable = util_format_is_srgb(visual->color_format);
mode->floatMode = util_format_is_float(visual->color_format);
}
if (visual->depth_stencil_format != PIPE_FORMAT_NONE) {

1
src/panfrost/ci/panfrost-t860-fails.txt
View file

@ -89,4 +89,3 @@ x11-dEQP-EGL.functional.create_context_ext.robust_gl_31.rgba8888_depth_stencil,F
x11-dEQP-EGL.functional.create_context_ext.robust_gl_31.rgba8888_no_depth_no_stencil,Fail
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail