fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-21 06:30:36 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

radv: do not use predication when the range doesn't cover the whole image

Browse source 
The predication is based on the mip level, so if the image has layers
and DCC is enabled, it should only be used if the range of layers
covers the whole image.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8368>
This commit is contained in:
Samuel Pitoiset 2021-01-07 18:39:52 +01:00 • committed by Marge Bot
parent 5420ab9cdf
commit 8754f9e8f9
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/amd/vulkan/radv_meta_fast_clear.c
View file

@ -740,12 +740,27 @@ radv_emit_color_decompress(struct radv_cmd_buffer *cmd_buffer,
const VkImageSubresourceRange *subresourceRange,
bool decompress_dcc)
{
bool use_predication = false;
bool old_predicating = false;
assert(cmd_buffer->queue_family_index == RADV_QUEUE_GENERAL);
if ((decompress_dcc && radv_dcc_enabled(image, subresourceRange->baseMipLevel)) ||
(!(radv_image_has_fmask(image) && !image->tc_compatible_cmask))) {
use_predication = true;
}
if (radv_dcc_enabled(image, subresourceRange->baseMipLevel) &&
(image->info.array_size != radv_get_layerCount(image, subresourceRange) ||
subresourceRange->baseArrayLayer != 0)) {
/* Only use predication if the image has DCC with mipmaps or
* if the range of layers covers the whole image because the
* predication is based on mip level.
*/
use_predication = false;
}
if (use_predication) {
uint64_t pred_offset = decompress_dcc ? image->dcc_pred_offset :
image->fce_pred_offset;
pred_offset += 8 * subresourceRange->baseMipLevel;
@ -759,8 +774,7 @@ radv_emit_color_decompress(struct radv_cmd_buffer *cmd_buffer,
radv_process_color_image(cmd_buffer, image, subresourceRange,
decompress_dcc);
if ((decompress_dcc && radv_dcc_enabled(image, subresourceRange->baseMipLevel)) ||
(!(radv_image_has_fmask(image) && !image->tc_compatible_cmask))) {
if (use_predication) {
uint64_t pred_offset = decompress_dcc ? image->dcc_pred_offset :
image->fce_pred_offset;
pred_offset += 8 * subresourceRange->baseMipLevel;