From 874cba5743e656d23e774f0c0a20628d41d96f19 Mon Sep 17 00:00:00 2001 From: Icenowy Zheng Date: Fri, 20 Mar 2026 15:26:51 +0800 Subject: [PATCH] pvr: fix "obb" typo in oob_buffer_size when building vertex pds data The ddmadt_oob_buffer_size structure to be filled is named `obb_buffer_size`, which is obviously a typo. Change to `oob_buffer_size` to fix the typo. Fixes: 8991e646411b ("pvr: Add a Vulkan driver for Imagination Technologies PowerVR Rogue GPUs") Signed-off-by: Icenowy Zheng Reviewed-by: Ella Stanforth (cherry picked from commit caea72cffc1ef906927b44b51f5a7d361f588b19) Part-of: --- .pick_status.json | 2 +- src/imagination/vulkan/pds/pvr_pipeline_pds.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 8f84c0c3c75..f3c85943137 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1874,7 +1874,7 @@ "description": "pvr: fix \"obb\" typo in oob_buffer_size when building vertex pds data", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "8991e646411b73c1e03278267c80758e921f2352", "notes": null diff --git a/src/imagination/vulkan/pds/pvr_pipeline_pds.c b/src/imagination/vulkan/pds/pvr_pipeline_pds.c index c48475e3c08..dab6c2925a5 100644 --- a/src/imagination/vulkan/pds/pvr_pipeline_pds.c +++ b/src/imagination/vulkan/pds/pvr_pipeline_pds.c @@ -1094,15 +1094,15 @@ void pvr_pds_generate_vertex_primary_program( if (use_robust_vertex_fetch) { struct pvr_pds_const_map_entry_vertex_attr_ddmadt_oob_buffer_size - *obb_buffer_size; - obb_buffer_size = + *oob_buffer_size; + oob_buffer_size = pvr_prepare_next_pds_const_map_entry(&entry_write_state, - sizeof(*obb_buffer_size)); + sizeof(*oob_buffer_size)); - obb_buffer_size->type = + oob_buffer_size->type = PVR_PDS_CONST_MAP_ENTRY_TYPE_VERTEX_ATTR_DDMADT_OOB_BUFFER_SIZE; - obb_buffer_size->const_offset = const_base + 7; - obb_buffer_size->binding_index = vertex_dma->binding_index; + oob_buffer_size->const_offset = const_base + 7; + oob_buffer_size->binding_index = vertex_dma->binding_index; } else { literal_entry = pvr_prepare_next_pds_const_map_entry(&entry_write_state,