From 8395d77ccbf8da2211a734807560fd57ef9deceb Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Fri, 22 Aug 2025 15:58:21 +0300 Subject: [PATCH] brw: remove uniform from opt_offsets Those are for push constants, no point in doing that because : - there is no HW constant offsets in push constants (payload delivery), it's just register offset calculation - if we have an dynamic value it's already using MOV_INDIRECT Signed-off-by: Lionel Landwerlin Fixes: e103afe7be ("brw: run the nir_opt_offsets pass and set the maximum offset size") Reviewed-by: Kenneth Graunke Part-of: (cherry picked from commit 27c69acb6a34d4a492a7bbd933ff759d2441e8d6) --- .pick_status.json | 2 +- src/intel/compiler/brw_nir.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index ae5f909e0a1..0bb39290ba9 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -4304,7 +4304,7 @@ "description": "brw: remove uniform from opt_offsets", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "e103afe7bec5eb509bf11ea62148a3db61a9eeaa", "notes": null diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index 6f2a570c0bb..65ece995f9f 100644 --- a/src/intel/compiler/brw_nir.c +++ b/src/intel/compiler/brw_nir.c @@ -1948,7 +1948,6 @@ brw_vectorize_lower_mem_access(nir_shader *nir, .buffer_max = UINT32_MAX, .shared_max = UINT32_MAX, .shared_atomic_max = UINT32_MAX, - .uniform_max = UINT32_MAX, }; OPT(nir_opt_offsets, &offset_options);