From 831085afa3f68cef851dca7e50f979a375dab548 Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Thu, 17 Aug 2023 17:51:15 -0500 Subject: [PATCH] nir: Fix metadata in nir_lower_is_helper_invocation It does not preserve everything. It adds and removes instructions and even adds a variable. Fixes: f17b41ab4f01 ("nir: add lowering pass for helperInvocationEXT()") Reviewed-by: Alyssa Rosenzweig Acked-by: Mike Blumenkrantz Part-of: --- src/compiler/nir/nir_lower_is_helper_invocation.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_is_helper_invocation.c b/src/compiler/nir/nir_lower_is_helper_invocation.c index a85e582c1c7..ab22df4ad60 100644 --- a/src/compiler/nir/nir_lower_is_helper_invocation.c +++ b/src/compiler/nir/nir_lower_is_helper_invocation.c @@ -116,6 +116,7 @@ nir_lower_is_helper_invocation(nir_shader *shader) return nir_shader_instructions_pass(shader, nir_lower_load_and_store_is_helper, - nir_metadata_all, + nir_metadata_block_index | + nir_metadata_dominance, is_helper_deref); }