fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-03 16:28:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

glsl: don't dead code remove SSO varyings marked as active

Browse source 
GL_ARB_separate_shader_objects allow matching by name variable or block
interface. Input varyings can't be removed because it is will impact the
location assignment.

This fixes the bug 79783 and likely any application that uses
GL_ARB_separate_shader_objects extension.

V2 (by Timothy Arceri):
* simplify now that builtins are not set as always active

Signed-off-by: Gregory Hainaut <gregory.hainaut@gmail.com>
Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
https://bugs.freedesktop.org/show_bug.cgi?id=79783
This commit is contained in:
Gregory Hainaut 2015-10-25 15:01:35 +01:00 • committed by Timothy Arceri
parent 618612f867
commit 8117f46f49
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/glsl/opt_dead_code.cpp
View file

@ -75,6 +75,20 @@ do_dead_code(exec_list *instructions, bool uniform_locations_assigned)
|| !entry->declaration)
continue;
/* Section 7.4.1 (Shader Interface Matching) of the OpenGL 4.5
* (Core Profile) spec says:
*
* "With separable program objects, interfaces between shader
* stages may involve the outputs from one program object and the
* inputs from a second program object. For such interfaces, it is
* not possible to detect mismatches at link time, because the
* programs are linked separately. When each such program is
* linked, all inputs or outputs interfacing with another program
* stage are treated as active."
*/
if (entry->var->data.always_active_io)
continue;
if (!entry->assign_list.is_empty()) {
/* Remove all the dead assignments to the variable we found.
* Don't do so if it's a shader or function output, though.