fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-06 21:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

virgl: Disable cache for VIRGL_BIND_SAMPLER_VIEW

Browse source 
this currently makes the dEQP-GLES31.functional.image_load_store.buffer.image_size.readonly_12
test fail when used simultaneously with other tests that lead to hitting the cache.

For instance the combination of:
dEQP-GLES31.functional.image_load_store.buffer.atomic.or_r32i_result
dEQP-GLES31.functional.image_load_store.buffer.atomic.or_r32i_return_value
dEQP-GLES31.functional.image_load_store.buffer.image_size.readonly_12

results in a failure of the readonly_12 test.

Deflag dEQP-GLES31.functional.image_load_store.buffer.image_size.{read,write}only_12 as flakes.

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14045>
This commit is contained in:
Corentin Noël 2021-12-03 16:15:58 +01:00 • committed by Marge Bot
parent 555f93cdcd
commit 7fa60cd7ce
3 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/gallium/drivers/virgl/ci/virgl-gl-flakes.txt
View file

@ -5,9 +5,6 @@ KHR-GL30.shaders30.glsl_constructors.bvec4_from_mat4x3_vs
# https://gitlab.freedesktop.org/mesa/mesa/-/issues/4651
KHR-GL31.transform_feedback.capture_special_interleaved_test
dEQP-GLES31.functional.image_load_store.buffer.image_size.writeonly_12
dEQP-GLES31.functional.image_load_store.buffer.image_size.readonly_12
dEQP-GLES2.functional.clipping.point.wide_point_clip
dEQP-GLES2.functional.clipping.point.wide_point_clip_viewport_center
dEQP-GLES2.functional.clipping.point.wide_point_clip_viewport_corner

3
src/gallium/drivers/virgl/ci/virgl-gles-flakes.txt
View file

@ -5,9 +5,6 @@ KHR-GL30.shaders30.glsl_constructors.bvec4_from_mat4x3_vs
# https://gitlab.freedesktop.org/mesa/mesa/-/issues/4651
KHR-GL31.transform_feedback.capture_special_interleaved_test
dEQP-GLES31.functional.image_load_store.buffer.image_size.writeonly_12
dEQP-GLES31.functional.image_load_store.buffer.image_size.readonly_12
dEQP-GLES2.functional.clipping.point.wide_point_clip
dEQP-GLES2.functional.clipping.point.wide_point_clip_viewport_center
dEQP-GLES2.functional.clipping.point.wide_point_clip_viewport_corner

1
src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
View file

@ -67,7 +67,6 @@ static inline boolean can_cache_resource(uint32_t bind)
bind == VIRGL_BIND_CUSTOM ||
bind == VIRGL_BIND_STAGING ||
bind == VIRGL_BIND_DEPTH_STENCIL ||
bind == VIRGL_BIND_SAMPLER_VIEW ||
bind == VIRGL_BIND_RENDER_TARGET ||
bind == 0;
}