fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 08:50:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel: Delete devinfo->must_use_separate_stencil

Browse source 
This is used by a single place in ISL only for sanity checking the
decisions it has already made.  The knowledge is already all centralized
in ISL these days, so we don't need a device info bit.

Reviewed-by: Dylan Baker <dylan.c.baker@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33764>
This commit is contained in:
Kenneth Graunke 2025-02-24 19:25:14 -08:00
parent 59c9bfa8f3
commit 7f50f1591b
3 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/intel/dev/intel_device_info.c
View file

@ -235,7 +235,6 @@ static const struct intel_device_info intel_device_info_snb_gt2 = {
#define GFX7_FEATURES \
.ver = 7, \
.has_hiz_and_separate_stencil = true, \
.must_use_separate_stencil = true, \
.has_llc = true, \
.has_pln = true, \
.has_64bit_float = true, \
@ -427,7 +426,6 @@ static const struct intel_device_info intel_device_info_hsw_gt3 = {
#define GFX8_FEATURES \
.ver = 8, \
.has_hiz_and_separate_stencil = true, \
.must_use_separate_stencil = true, \
.has_llc = true, \
.has_sample_with_hiz = false, \
.has_pln = true, \

1
src/intel/dev/intel_device_info.py
View file

@ -270,7 +270,6 @@ Struct("intel_device_info",
Member("uint8_t", "pci_revision_id"),
Member("intel_platform", "platform", compiler_field=True),
Member("bool", "has_hiz_and_separate_stencil"),
Member("bool", "must_use_separate_stencil"),
Member("bool", "has_sample_with_hiz"),
Member("bool", "has_bit6_swizzle"),
Member("bool", "has_llc"),

3
src/intel/isl/isl.c
View file

@ -320,6 +320,7 @@ isl_device_init(struct isl_device *dev,
assert(!(info->has_bit6_swizzle && info->ver >= 8));
dev->info = info;
/* A must on Gfx7+, preferred on Gfx6, first possible on Gfx5 */
dev->use_separate_stencil = ISL_GFX_VER(dev) >= 6;
dev->has_bit6_swizzling = info->has_bit6_swizzle;
dev->buffer_length_in_aux_addr = false;
@ -334,8 +335,6 @@ isl_device_init(struct isl_device *dev,
/* Did we break hiz or stencil? */
if (dev->use_separate_stencil)
assert(info->has_hiz_and_separate_stencil);
if (info->must_use_separate_stencil)
assert(dev->use_separate_stencil);
dev->ss.size = RENDER_SURFACE_STATE_length(info) * 4;
dev->ss.align = isl_align(dev->ss.size, 32);