From 7f29cae6bc2a7c996f4fc5444b5fb97d41b9d985 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 1 May 2026 11:56:31 -0400 Subject: [PATCH] vk/cmd_queue: always ceil() param lens this avoids rounding errors with pSampleMask for 64bit masks cc: mesa-stable Part-of: (cherry picked from commit 95954b098190dc24f0c555db7dfbe0cb0f6feefb) --- .pick_status.json | 2 +- src/vulkan/util/vk_cmd_queue_gen.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 43ff488ab28..30d00b00428 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1604,7 +1604,7 @@ "description": "vk/cmd_queue: always ceil() param lens", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/vulkan/util/vk_cmd_queue_gen.py b/src/vulkan/util/vk_cmd_queue_gen.py index eaf32432347..4c74158f11e 100644 --- a/src/vulkan/util/vk_cmd_queue_gen.py +++ b/src/vulkan/util/vk_cmd_queue_gen.py @@ -674,7 +674,7 @@ def get_param_copy(builder, command, types, src_parent_access, dst_parent_access is_ndarray = param.len and "," in param.len if param.len and param.len != "struct-ptr" and not is_ndarray: - size = "%s * %s%s" % (size, src_parent_access, param.len) + size = "%s * ceil(%s%s)" % (size, src_parent_access, param.len) builder.add("%s = linear_alloc_child(queue->ctx, %s);" % (dst, size)) builder.add("if (%s == NULL) return NULL;" % (dst))