From 7efabfbbe4f5ae442e62803a7e173bd2bf20001a Mon Sep 17 00:00:00 2001 From: Hans-Kristian Arntzen Date: Sun, 12 Feb 2023 16:02:26 +0100 Subject: [PATCH] radv: Fix missing VK_ACCESS_2_SHADER_SAMPLED_READ_BIT. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cannot be used for SSBO, so ignore SCACHE invalidation. Signed-off-by: Hans-Kristian Arntzen Fixes: 8df17163c78 ("radv: implement vkCmdWaitEvents2KHR") Reviewed-by: Timur Kristóf Part-of: --- src/amd/vulkan/radv_cmd_buffer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 5a02befa8e5..dd2b9c374c9 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -5426,12 +5426,13 @@ radv_dst_access_flush(struct radv_cmd_buffer *cmd_buffer, VkAccessFlags2 dst_fla case VK_ACCESS_2_SHADER_BINDING_TABLE_READ_BIT_KHR: case VK_ACCESS_2_SHADER_READ_BIT: case VK_ACCESS_2_SHADER_STORAGE_READ_BIT: - flush_bits |= RADV_CMD_FLAG_INV_VCACHE; /* Unlike LLVM, ACO uses SMEM for SSBOs and we have to * invalidate the scalar cache. */ if (!cmd_buffer->device->physical_device->use_llvm && !image) flush_bits |= RADV_CMD_FLAG_INV_SCACHE; - + FALLTHROUGH; + case VK_ACCESS_2_SHADER_SAMPLED_READ_BIT: + flush_bits |= RADV_CMD_FLAG_INV_VCACHE; if (has_CB_meta || has_DB_meta) flush_bits |= RADV_CMD_FLAG_INV_L2_METADATA; if (!image_is_coherent)