fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 08:40:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

agx: add unit test for ballot bug

Browse source 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29861>
This commit is contained in:
Alyssa Rosenzweig 2024-06-17 17:52:28 -04:00
parent 6628f24e4d
commit 7dd73290fb
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/asahi/compiler/test/test-optimizer.cpp
View file

@ -293,6 +293,33 @@ TEST_F(Optimizer, BallotMultipleUses)
});
}
/*
* We had a bug where the ballot optimization didn't check the agx_index's type
* so would fuse constants with overlapping values. An unrelated common code
* change surfaced this in CTS case:
*
* dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_bool_fragment
*
* We passed Vulkan CTS without hitting it though, hence the targeted test.
*/
TEST_F(Optimizer, BallotConstant)
{
CASE32(
{
agx_index cmp = agx_fcmp(b, wx, wy, AGX_FCOND_GT, false);
agx_index ballot = agx_quad_ballot(b, agx_immediate(cmp.value));
agx_index ballot2 = agx_quad_ballot(b, cmp);
agx_fadd_to(b, out, ballot, agx_fadd(b, ballot2, cmp));
},
{
agx_index cmp = agx_fcmp(b, wx, wy, AGX_FCOND_GT, false);
agx_index ballot = agx_quad_ballot(b, agx_immediate(cmp.value));
agx_index ballot2 =
agx_fcmp_quad_ballot(b, wx, wy, AGX_FCOND_GT, false);
agx_fadd_to(b, out, ballot, agx_fadd(b, ballot2, cmp));
});
}
TEST_F(Optimizer, IfCondition)
{
CASE_NO_RETURN(agx_if_icmp(b, agx_icmp(b, wx, wy, AGX_ICOND_UEQ, true),