fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-31 22:50:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

i965: Make src_reg::equals() take a constant reference, not a pointer.

Browse source 
This is more typical C++ style.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>
This commit is contained in:
Kenneth Graunke 2013-03-06 08:51:44 -08:00
parent 000f4a33c0
commit 7b9cf79790
3 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/mesa/drivers/dri/i965/brw_vec4.cpp
View file

@ -323,19 +323,19 @@ vec4_visitor::implied_mrf_writes(vec4_instruction *inst)
}
bool
src_reg::equals(src_reg *r)
src_reg::equals(const src_reg &r) const
{
return (file == r->file &&
reg == r->reg &&
reg_offset == r->reg_offset &&
type == r->type &&
negate == r->negate &&
abs == r->abs &&
swizzle == r->swizzle &&
!reladdr && !r->reladdr &&
memcmp(&fixed_hw_reg, &r->fixed_hw_reg,
return (file == r.file &&
reg == r.reg &&
reg_offset == r.reg_offset &&
type == r.type &&
negate == r.negate &&
abs == r.abs &&
swizzle == r.swizzle &&
!reladdr && !r.reladdr &&
memcmp(&fixed_hw_reg, &r.fixed_hw_reg,
sizeof(fixed_hw_reg)) == 0 &&
imm.u == r->imm.u);
imm.u == r.imm.u);
}
static bool

2
src/mesa/drivers/dri/i965/brw_vec4.h
View file

@ -126,7 +126,7 @@ public:
src_reg(int32_t i);
src_reg(struct brw_reg reg);
bool equals(src_reg *r);
bool equals(const src_reg &r) const;
bool is_zero() const;
bool is_one() const;
bool is_accumulator() const;

4
src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp
View file

@ -82,7 +82,7 @@ try_constant_propagation(vec4_instruction *inst, int arg, src_reg *values[4])
*/
src_reg value = *values[0];
for (int i = 1; i < 4; i++) {
if (!value.equals(values[i]))
if (!value.equals(*values[i]))
return false;
}
@ -289,7 +289,7 @@ vec4_visitor::try_copy_propagation(vec4_instruction *inst, int arg,
return false;
/* Don't report progress if this is a noop. */
if (value.equals(&inst->src[arg]))
if (value.equals(inst->src[arg]))
return false;
value.type = inst->src[arg].type;