From 7b32df696e87810f8e738d113521d98a56c0ed0e Mon Sep 17 00:00:00 2001 From: Mauro Rossi Date: Sat, 24 Aug 2024 19:30:18 +0200 Subject: [PATCH] nvk: Fix regression observed on Kepler vkcube, vkgears and vkmark are crashing with the following error/segfault: $ NVK_I_WANT_A_BROKEN_VULKAN_DRIVER=1 vkcube WARNING: NVK is not a conformant Vulkan implementation, testing use only. Selected GPU 0: GeForce GT 640 (NVK GK107), type: DiscreteGpu ERROR: couldn't get DataFile for op ldc_nv Segmentation fault (core dumped) Handling nir_intrinsic_ldc_nv as per nir_intrinsic_load_ubo in Converter::getFile() allows to run vkcube, vkgears and vkmark on Nvidia GT640 Fixes: dc99d9b2 ("nvk,nak: Switch to nir_intrinsic_ldc_nv") Reviewed-by: Karol Herbst Part-of: --- src/nouveau/codegen/nv50_ir_from_nir.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/nouveau/codegen/nv50_ir_from_nir.cpp b/src/nouveau/codegen/nv50_ir_from_nir.cpp index afd94bb490a..9d8f48fcedf 100644 --- a/src/nouveau/codegen/nv50_ir_from_nir.cpp +++ b/src/nouveau/codegen/nv50_ir_from_nir.cpp @@ -379,6 +379,7 @@ Converter::getFile(nir_intrinsic_op op) const switch (op) { case nir_intrinsic_load_uniform: case nir_intrinsic_load_ubo: + case nir_intrinsic_ldc_nv: return FILE_MEMORY_CONST; case nir_intrinsic_load_ssbo: case nir_intrinsic_store_ssbo: