From 7aef59ccd2c56fd1713b116f4ccd804da19f503d Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Mon, 30 Aug 2021 11:37:06 -0400 Subject: [PATCH] radv: add some asserts for descriptor updating let's avoid any further issues with descriptor sizing Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_descriptor_set.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index 1ea9ce607d8..de8a3ce90d9 100644 --- a/src/amd/vulkan/radv_descriptor_set.c +++ b/src/amd/vulkan/radv_descriptor_set.c @@ -966,6 +966,7 @@ write_buffer_descriptor(struct radv_device *device, struct radv_cmd_buffer *cmd_ if (buffer_info->range == VK_WHOLE_SIZE) range = buffer->size - buffer_info->offset; + assert(buffer->size > 0 && range > 0); /* robustBufferAccess is relaxed enough to allow this (in combination * with the alignment/size we return from vkGetBufferMemoryRequirements) @@ -1028,6 +1029,7 @@ write_dynamic_buffer_descriptor(struct radv_device *device, struct radv_descript if (buffer_info->range == VK_WHOLE_SIZE) size = buffer->size - buffer_info->offset; + assert(buffer->size > 0 && size > 0); /* robustBufferAccess is relaxed enough to allow this (in combination * with the alignment/size we return from vkGetBufferMemoryRequirements) @@ -1062,6 +1064,7 @@ write_image_descriptor(struct radv_device *device, struct radv_cmd_buffer *cmd_b } else { descriptor = &iview->descriptor; } + assert(size > 0); memcpy(dst, descriptor, size);