From 7ad4f501faeb40570d3162b1005f784bd3cd50c4 Mon Sep 17 00:00:00 2001 From: David Rosca Date: Fri, 30 Jan 2026 10:01:08 +0100 Subject: [PATCH] radv: Drop videoarraypath debug option It's not really usefull and only works for H264/5. On AV1/VP9 it would cause hang. Reviewed-by: Benjamin Cheng Reviewed-by: Ruijing Dong Part-of: --- src/amd/vulkan/radv_debug.h | 53 +++++++++++++++++----------------- src/amd/vulkan/radv_instance.c | 1 - src/amd/vulkan/radv_video.c | 4 +-- 3 files changed, 27 insertions(+), 31 deletions(-) diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h index da32a9a7874..289f0cf0e6f 100644 --- a/src/amd/vulkan/radv_debug.h +++ b/src/amd/vulkan/radv_debug.h @@ -48,33 +48,32 @@ enum { RADV_DEBUG_SHADOW_REGS = 1ull << 33, RADV_DEBUG_EXTRA_MD = 1ull << 34, RADV_DEBUG_NO_GPL = 1ull << 35, - RADV_DEBUG_VIDEO_ARRAY_PATH = 1ull << 36, - RADV_DEBUG_NO_RT = 1ull << 37, - RADV_DEBUG_NO_MESH_SHADER = 1ull << 38, - RADV_DEBUG_NO_ESO = 1ull << 39, - RADV_DEBUG_PSO_CACHE_STATS = 1ull << 40, - RADV_DEBUG_NIR_DEBUG_INFO = 1ull << 41, - RADV_DEBUG_DUMP_TRAP_HANDLER = 1ull << 42, - RADV_DEBUG_DUMP_VS = 1ull << 43, - RADV_DEBUG_DUMP_TCS = 1ull << 44, - RADV_DEBUG_DUMP_TES = 1ull << 45, - RADV_DEBUG_DUMP_GS = 1ull << 46, - RADV_DEBUG_DUMP_PS = 1ull << 47, - RADV_DEBUG_DUMP_TASK = 1ull << 48, - RADV_DEBUG_DUMP_MESH = 1ull << 49, - RADV_DEBUG_DUMP_CS = 1ull << 50, - RADV_DEBUG_DUMP_NIR = 1ull << 51, - RADV_DEBUG_DUMP_ASM = 1ull << 52, - RADV_DEBUG_DUMP_BACKEND_IR = 1ull << 53, - RADV_DEBUG_PSO_HISTORY = 1ull << 54, - RADV_DEBUG_BVH4 = 1ull << 55, - RADV_DEBUG_NO_VIDEO = 1ull << 56, - RADV_DEBUG_VALIDATE_VAS = 1ull << 57, - RADV_DEBUG_DUMP_BO_HISTORY = 1ull << 58, - RADV_DEBUG_NO_BO_LIST = 1ull << 59, - RADV_DEBUG_DUMP_IBS = 1ull << 60, - RADV_DEBUG_VM = 1ull << 61, - RADV_DEBUG_NO_SMEM_MITIGATION = 1ull << 62, + RADV_DEBUG_NO_RT = 1ull << 36, + RADV_DEBUG_NO_MESH_SHADER = 1ull << 37, + RADV_DEBUG_NO_ESO = 1ull << 38, + RADV_DEBUG_PSO_CACHE_STATS = 1ull << 39, + RADV_DEBUG_NIR_DEBUG_INFO = 1ull << 40, + RADV_DEBUG_DUMP_TRAP_HANDLER = 1ull << 41, + RADV_DEBUG_DUMP_VS = 1ull << 42, + RADV_DEBUG_DUMP_TCS = 1ull << 43, + RADV_DEBUG_DUMP_TES = 1ull << 44, + RADV_DEBUG_DUMP_GS = 1ull << 45, + RADV_DEBUG_DUMP_PS = 1ull << 46, + RADV_DEBUG_DUMP_TASK = 1ull << 47, + RADV_DEBUG_DUMP_MESH = 1ull << 48, + RADV_DEBUG_DUMP_CS = 1ull << 49, + RADV_DEBUG_DUMP_NIR = 1ull << 50, + RADV_DEBUG_DUMP_ASM = 1ull << 51, + RADV_DEBUG_DUMP_BACKEND_IR = 1ull << 52, + RADV_DEBUG_PSO_HISTORY = 1ull << 53, + RADV_DEBUG_BVH4 = 1ull << 54, + RADV_DEBUG_NO_VIDEO = 1ull << 55, + RADV_DEBUG_VALIDATE_VAS = 1ull << 56, + RADV_DEBUG_DUMP_BO_HISTORY = 1ull << 57, + RADV_DEBUG_NO_BO_LIST = 1ull << 58, + RADV_DEBUG_DUMP_IBS = 1ull << 59, + RADV_DEBUG_VM = 1ull << 60, + RADV_DEBUG_NO_SMEM_MITIGATION = 1ull << 61, RADV_DEBUG_DUMP_SHADERS = RADV_DEBUG_DUMP_VS | RADV_DEBUG_DUMP_TCS | RADV_DEBUG_DUMP_TES | RADV_DEBUG_DUMP_GS | RADV_DEBUG_DUMP_PS | RADV_DEBUG_DUMP_TASK | RADV_DEBUG_DUMP_MESH | RADV_DEBUG_DUMP_CS | RADV_DEBUG_DUMP_NIR | RADV_DEBUG_DUMP_ASM | RADV_DEBUG_DUMP_BACKEND_IR, diff --git a/src/amd/vulkan/radv_instance.c b/src/amd/vulkan/radv_instance.c index e185a47e588..6bfec568c04 100644 --- a/src/amd/vulkan/radv_instance.c +++ b/src/amd/vulkan/radv_instance.c @@ -64,7 +64,6 @@ static const struct debug_control radv_debug_options[] = { {"shadowregs", RADV_DEBUG_SHADOW_REGS}, {"extra_md", RADV_DEBUG_EXTRA_MD}, {"nogpl", RADV_DEBUG_NO_GPL}, - {"videoarraypath", RADV_DEBUG_VIDEO_ARRAY_PATH}, {"nort", RADV_DEBUG_NO_RT}, {"nomeshshader", RADV_DEBUG_NO_MESH_SHADER}, {"noeso", RADV_DEBUG_NO_ESO}, diff --git a/src/amd/vulkan/radv_video.c b/src/amd/vulkan/radv_video.c index b87790a718f..4a3b38d9acc 100644 --- a/src/amd/vulkan/radv_video.c +++ b/src/amd/vulkan/radv_video.c @@ -68,9 +68,7 @@ radv_enable_tier3(struct radv_physical_device *pdev, VkVideoCodecOperationFlagBi static bool radv_enable_tier2(struct radv_physical_device *pdev) { - const struct radv_instance *instance = radv_physical_device_instance(pdev); - - if (pdev->info.vcn_ip_version >= VCN_3_0_0 && !(instance->debug_flags & RADV_DEBUG_VIDEO_ARRAY_PATH)) + if (pdev->info.vcn_ip_version >= VCN_3_0_0) return true; return false; }