fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 13:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nir/fold_16bit_sampler_conversions: Don't fold dest upcasts.

Browse source 
This is not a valid optimization.

Fixes: fb29cef8dd ("nir: add many passes that lower and optimize 16-bit input/outputs and samplers")
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14895>
This commit is contained in:
Georg Lehmann 2022-03-23 11:44:57 +01:00 • committed by Marge Bot
parent 18111c3787
commit 798e47be51
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/compiler/nir/nir_lower_mediump.c
View file

@ -517,22 +517,15 @@ nir_fold_16bit_sampler_conversions(nir_shader *nir,
}
/* Optimize the destination. */
bool is_f16_to_f32 = true;
bool is_f32_to_f16 = true;
bool is_i16_to_i32 = true;
bool is_i32_to_i16 = true; /* same behavior for int and uint */
bool is_u16_to_u32 = true;
nir_foreach_use(use, &tex->dest.ssa) {
is_f16_to_f32 &= is_f16_to_f32_conversion(use->parent_instr);
is_f32_to_f16 &= is_f32_to_f16_conversion(use->parent_instr);
is_i16_to_i32 &= is_i16_to_i32_conversion(use->parent_instr);
is_i32_to_i16 &= is_i32_to_i16_conversion(use->parent_instr);
is_u16_to_u32 &= is_u16_to_u32_conversion(use->parent_instr);
}
if (is_f16_to_f32 || is_f32_to_f16 || is_i16_to_i32 ||
is_i32_to_i16 || is_u16_to_u32) {
if (is_f32_to_f16 || is_i32_to_i16) {
/* All uses are the same conversions. Replace them with mov. */
nir_foreach_use(use, &tex->dest.ssa) {
nir_alu_instr *conv = nir_instr_as_alu(use->parent_instr);