From 7968c474b8db2e49ab56ecdb353a3f294a1f2910 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Tue, 7 Feb 2023 13:27:08 -0500 Subject: [PATCH] panvk: Disable SNORM rendering Driver isn't ready for this yet. 7f98a9ba2bd ("panfrost: Implement GL_EXT_render_snorm on Bifrost+") caused piles of tests to go from NotSupported -> Fail, so let's functionally revert that. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/vulkan/panvk_formats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/panvk_formats.c b/src/panfrost/vulkan/panvk_formats.c index d36fd6657c4..008c338e0e1 100644 --- a/src/panfrost/vulkan/panvk_formats.c +++ b/src/panfrost/vulkan/panvk_formats.c @@ -82,7 +82,8 @@ get_format_properties(struct panvk_physical_device *physical_device, tex |= VK_FORMAT_FEATURE_BLIT_SRC_BIT; } - if (fmt.bind & PIPE_BIND_RENDER_TARGET) { + /* SNORM rendering isn't working yet, disable */ + if (fmt.bind & PIPE_BIND_RENDER_TARGET && !util_format_is_snorm(pfmt)) { tex |= VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT | VK_FORMAT_FEATURE_BLIT_DST_BIT;